10-07-2018, 09:46 AM
Just found a huge design flaw in the source for IWBSRegion. I was trying to create a sidebar and I needed to put a fluid container inside a navbar. As soon as I did so, it added an extra "navbar-btn" class!
Here is the flawed code:
if (Parent is TIWBSNavBar) then
if TagType = bsttDiv then
TIWBSCommon.AddCssClass(ACss, 'navbar-btn')
else
TIWBSCommon.AddCssClass(ACss, 'navbar-text');
This code makes it impossible to add a container that is not a button. It should be a separate component, or a property.
I have already made a pull request on the project on GitHub. I'll make another for this. The biggest problem here is that fixing the mistake can break existing code
Here is the flawed code:
if (Parent is TIWBSNavBar) then
if TagType = bsttDiv then
TIWBSCommon.AddCssClass(ACss, 'navbar-btn')
else
TIWBSCommon.AddCssClass(ACss, 'navbar-text');
This code makes it impossible to add a container that is not a button. It should be a separate component, or a property.
I have already made a pull request on the project on GitHub. I'll make another for this. The biggest problem here is that fixing the mistake can break existing code

