Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Bootstrap Side Bar
#2
Just found a huge design flaw in the source for IWBSRegion. I was trying to create a sidebar and I needed to put a fluid container inside a navbar. As soon as I did so, it added an extra "navbar-btn" class!

Here is the flawed code:

if (Parent is TIWBSNavBar) then
if TagType = bsttDiv then
TIWBSCommon.AddCssClass(ACss, 'navbar-btn')
else
TIWBSCommon.AddCssClass(ACss, 'navbar-text');

This code makes it impossible to add a container that is not a button. It should be a separate component, or a property.

I have already made a pull request on the project on GitHub. I'll make another for this. The biggest problem here is that fixing the mistake can break existing code Sad
Reply


Messages In This Thread
Bootstrap Side Bar - by ShaneStump - 10-07-2018, 12:32 AM
RE: Bootstrap Side Bar - by LorenSzendre - 10-07-2018, 09:46 AM
RE: Bootstrap Side Bar - by ShaneStump - 10-07-2018, 02:04 PM
RE: Bootstrap Side Bar - by kudzu - 10-07-2018, 04:52 PM

Forum Jump:


Users browsing this thread: 1 Guest(s)